add the graham scan in go #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
june128
added
the
Implementation
|
Hey @Liikt We are currently waiting on a review for golang. I don't know if we have too much expertise in the language. If no one steps up, I'll do the review, but I might ask dumb questions because I don't know the best practices in golang. Just letting you know what's happening with this PR and #403, #404, #405, #406 |
|
Sure thing. I'd be happy to answer any questions. |
zsparal
approved these changes
Oct 9, 2018
zsparal
suggested changes
Oct 9, 2018
contents/graham_scan/graham_scan.md
Outdated
| @@ -22,8 +22,14 @@ We can find whether a rotation is counter-clockwise with trigonometric functions | |||
| [import:36-38, lang:"javascript"](code/javascript/graham-scan.js) | |||
| {% sample lang="py" %} | |||
| [import:4-6, lang:"python"](code/python/grahamScan.py) | |||
| {% sample lang="go" %} | |||
| <<<<<<< HEAD | |||
zsparal
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compiled with
go version go1.11 linux/amd64and has no errors